This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: Merge loadLibrary calls for sentry-native and clean up CMake files#373
Merged
marandaneto merged 3 commits intomasterfrom Apr 23, 2020
Merged
fix: Merge loadLibrary calls for sentry-native and clean up CMake files#373marandaneto merged 3 commits intomasterfrom
marandaneto merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
Don’t get your hopes up to soon. I have no idea if this actually fixes the problem :-D |
Member
|
lol. Well, worth the shot |
marandaneto
reviewed
Apr 22, 2020
Contributor
yeah its a try :) thx for that, left a comment btw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This loads all the non-essential-system libraries explicitly in order, to hopefully avoid dynamic linker errors such as #341
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps