Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

enha: end session when user kills the App. #423

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

enha: end session when user kills the App. #423

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0808773
enha: end session when user kills the App.
marandaneto May 19, 2020
3f80265
fix comments
marandaneto May 19, 2020
8fa9236
add comments
marandaneto May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comments
  • Loading branch information
@marandaneto
marandaneto committed May 19, 2020
commit 3f80265027f86ebe358f987ec46c4e4fe2d04ecf
5 changes: 3 additions & 2 deletions sentry-android-core/src/main/java/io/sentry/android/core/SentryService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import org.jetbrains.annotations.Nullable;

/**
* This is a best effort to end a session during onTaskRemoved (user swapped up the App. aka killed
* it). It needs to be public.
* This is a best effort to end a session during onTaskRemoved (user swiped up the App. aka killed
* it. It needs to be public.
*/
@ApiStatus.Internal
public final class SentryService extends Service {
Expand All @@ -29,6 +29,7 @@ public final class SentryService extends Service {
@Override
public int onStartCommand(Intent intent, int flags, int startId) {
super.onStartCommand(intent, flags, startId);
// START_NOT_STICKY, we don't want to recreate the service nor the AppContext.
return START_NOT_STICKY;
}

Expand Down