Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

a few warnings have been fixed.

💡 Motivation and Context

warnings were annoying.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #51 into master will increase coverage by 0.6%.
The diff coverage is 6.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #51     +/-   ##
===========================================
+ Coverage     38.13%   38.74%   +0.6%     
- Complexity      169      185     +16     
===========================================
  Files            51       51             
  Lines          1340     1368     +28     
  Branches         66       78     +12     
===========================================
+ Hits            511      530     +19     
- Misses          802      811      +9     
  Partials         27       27
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/io/sentry/core/EnvelopeReader.java 85.56% <ø> (-0.15%) 17 <0> (ø)
...src/main/java/io/sentry/core/DiagnosticLogger.java 92.85% <ø> (ø) 11 <0> (ø) ⬇️
...ntry-core/src/main/java/io/sentry/core/Sentry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...-core/src/main/java/io/sentry/core/NoOpLogger.java 100% <100%> (ø) 5 <1> (ø) ⬇️
...entry-core/src/main/java/io/sentry/core/Scope.java 62.06% <100%> (+44.82%) 11 <1> (+10) ⬆️
sentry-core/src/main/java/io/sentry/core/Hub.java 18.18% <2.27%> (-8.97%) 4 <0> (ø)
...-core/src/main/java/io/sentry/core/Breadcrumb.java 19.04% <0%> (+19.04%) 3% <0%> (+3%) ⬆️
...re/src/main/java/io/sentry/core/protocol/User.java 22.22% <0%> (+22.22%) 3% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ac779...e33ee3a. Read the comment docs.

@marandaneto marandaneto merged commit a623feb into master Oct 23, 2019
@marandaneto marandaneto deleted the ref/android_lint branch October 23, 2019 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants