This repository was archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat: NDK #52
Merged
Merged
feat: NDK #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#modified: sentry-android/build.gradle.kts
Co-Authored-By: Manoel Aranda Neto <[email protected]>
Co-Authored-By: Manoel Aranda Neto <[email protected]>
Co-Authored-By: Manoel Aranda Neto <[email protected]>
Co-Authored-By: Manoel Aranda Neto <[email protected]>
Closed
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage ? 38%
Complexity ? 186
=======================================
Files ? 51
Lines ? 1413
Branches ? 69
=======================================
Hits ? 537
Misses ? 850
Partials ? 26
Continue to review full report at Codecov.
|
marandaneto
reviewed
Oct 23, 2019
marandaneto
reviewed
Oct 23, 2019
tonyo
suggested changes
Oct 23, 2019
|
@bruno-garcia Added a check, now we should only building NDK for a specific platform set via Travis environment variable |
…gument. Co-Authored-By: Anton Ovchinnikov <[email protected]>
Co-Authored-By: Anton Ovchinnikov <[email protected]>
Co-Authored-By: Anton Ovchinnikov <[email protected]>
5649018 to
5f43c79
Compare
f691d68 to
adc8f19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to solve a few things before merging this:
Should we postpone merging while the main SDK is heavy under development and just bring master to this branch until then?
Introduce a build with/without NDK to run the lower API levels?