Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@bruno-garcia
Copy link
Member

We need to solve a few things before merging this:

  1. Builds go from 2-5 minutes to 10-20.
    Should we postpone merging while the main SDK is heavy under development and just bring master to this branch until then?
  2. CI builds from API > 14.
    Introduce a build with/without NDK to run the lower API levels?

bruno-garcia and others added 27 commits October 4, 2019 11:47
	#modified:   sentry-android/build.gradle.kts
@bruno-garcia bruno-garcia mentioned this pull request Oct 22, 2019
@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0e1fe4d). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #52   +/-   ##
=======================================
  Coverage          ?    38%           
  Complexity        ?    186           
=======================================
  Files             ?     51           
  Lines             ?   1413           
  Branches          ?     69           
=======================================
  Hits              ?    537           
  Misses            ?    850           
  Partials          ?     26
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/io/sentry/core/SentryOptions.java 72.6% <66.66%> (ø) 29 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1fe4d...3613ee2. Read the comment docs.

@tonyo tonyo changed the title feat: NDK [WIP] feat: NDK Oct 23, 2019
@tonyo
Copy link

tonyo commented Oct 23, 2019

@bruno-garcia Added a check, now we should only building NDK for a specific platform set via Travis environment variable ABI (looks like it's currently not used for anything else).
But just to keep in mind, when performing a release build, we should build all of them.

@bruno-garcia bruno-garcia changed the title [WIP] feat: NDK feat: NDK Oct 23, 2019
@bruno-garcia bruno-garcia merged commit d815162 into master Oct 23, 2019
@bruno-garcia bruno-garcia deleted the feat/ndk-submodule branch October 23, 2019 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants