Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename SentryCommonOptions to SentryBindableOptions.
  • Loading branch information
maciejwalkowiak committed Aug 28, 2020
commit f842c320c44c0ca66f05b8f4ea771349562ec553
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

/** Subset of {@link SentryOptions} properties used in 3rd party framework integrations. */
/**
* Subset of {@link SentryOptions} properties bindable from text, extracted to separate class to be
* used in 3rd party framework integrations.
*/
@Open
public class SentryCommonOptions {
public class SentryBindableOptions {

/**
* The DSN tells the SDK where to send the events to. If this value is not provided, the SDK will
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

/** Sentry SDK options */
@Open
public class SentryOptions extends SentryCommonOptions {
public class SentryOptions extends SentryBindableOptions {

/** Default Log level if not specified Default is DEBUG */
static final SentryLevel DEFAULT_DIAGNOSTIC_LEVEL = SentryLevel.DEBUG;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertTrue

class SentryCommonOptionsTest {
class SentryBindableOptionsTest {

@Test
fun `applies properties to SentryOptions`() {
val commonOptions = with(SentryCommonOptions()) {
val commonOptions = with(SentryBindableOptions()) {
dsn = "http://key@localhost/proj"
readTimeoutMillis = 10
shutdownTimeout = 20L
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package io.sentry.spring.boot;

import com.jakewharton.nopen.annotation.Open;
import io.sentry.core.SentryCommonOptions;
import io.sentry.core.SentryBindableOptions;
import org.springframework.boot.context.properties.ConfigurationProperties;

/** Configuration for Sentry integration. */
@ConfigurationProperties(prefix = "sentry")
@Open
public class SentrySpringProperties extends SentryCommonOptions {
public class SentrySpringProperties extends SentryBindableOptions {
/** Whether Sentry integration should be enabled. */
private boolean enabled = true;

Expand Down