init. ndk only if ndk opt on manifest is enabled

[marandaneto]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

Init. NDK only if sdk opt is enabled.

💡 Motivation and Context

Right now is trying to load every time.

💚 How did you test it?

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing

🔮 Next steps

Write tests

[bruno-garcia]

One comment to confirm.
Also, we need to create dir now on a new PR?
Otherwise lgtm.

[codecov-io]

Codecov Report

Merging #60 into master will decrease coverage by 5.96%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     44.66%   38.69%   -5.97%     
+ Complexity      243      185      -58     
============================================
  Files            52       51       -1     
  Lines          1442     1367      -75     
  Branches         90       78      -12     
============================================
- Hits            644      529     -115     
- Misses          766      811      +45     
+ Partials         32       27       -5

Impacted Files	Coverage Δ	Complexity Δ
...re/src/main/java/io/sentry/core/SentryOptions.java	73.91% <ø> (-5.75%)	21 <0> (-8)
...ain/java/io/sentry/core/protocol/SentryThread.java	0% <0%> (-81.49%)	0% <0%> (-14%)
...ore/src/main/java/io/sentry/core/SentryValues.java	0% <0%> (-50%)	0% <0%> (-1%)
...java/io/sentry/core/protocol/SentryStackTrace.java	0% <0%> (-44.45%)	0% <0%> (-2%)
...java/io/sentry/core/protocol/SentryStackFrame.java	0% <0%> (-19.3%)	0% <0%> (-6%)
sentry-core/src/main/java/io/sentry/core/Hub.java	18.18% <0%> (-9.71%)	4% <0%> (-4%)
...core/src/main/java/io/sentry/core/SentryEvent.java	18.39% <0%> (-9.7%)	6% <0%> (-6%)
...entry-core/src/main/java/io/sentry/core/Scope.java	62.06% <0%> (-6.9%)	11% <0%> (-1%)
...ore/src/main/java/io/sentry/core/SentryClient.java	70.27% <0%> (-4.73%)	9% <0%> (-3%)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe98c7...1ccb641. Read the comment docs.

[ninniuz]

Are we settling on the fact that NDK support will not be available on API < 21?

[marandaneto]

@ninniuz for the first release, probably yes, we have a system blocker and trying to find a workaround.
JFYI dl_iterate_phdr method only available API >= 21
https://android.googlesource.com/platform/bionic/+/master/docs/status.md

[ninniuz]

Yeah, tried to build the NDK feature branch on API 14 and got an error on that method :(

[marandaneto]

we might have a workaround, parsing /proc/PID/maps by hand and getting what we need.
but still thinking if it's a good idea.

[marandaneto]

@bruno-garcia the configuration will be to avoid a reflection call if we already know NDK is not there or disabled.
Reflection on Android is expensive.