Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Implements inApp prefix for stack traces, so if the stack traces contain our packages, the noise is hidden and the user may focus on the real problem.

💡 Motivation and Context

stack traces contain noise if our packages appear there.

💚 How did you test it?

unit testing

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@460dbd3). Click here to learn what that means.
The diff coverage is 72.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   49.33%           
  Complexity        ?      360           
=========================================
  Files             ?       59           
  Lines             ?     1792           
  Branches          ?      143           
=========================================
  Hits              ?      884           
  Misses            ?      856           
  Partials          ?       52
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/sentry/core/SentryThreadFactory.java 100% <100%> (ø) 10 <1> (?)
...in/java/io/sentry/core/SentryExceptionFactory.java 91.66% <100%> (ø) 7 <1> (?)
...c/main/java/io/sentry/core/MainEventProcessor.java 58.33% <50%> (ø) 4 <1> (?)
...re/src/main/java/io/sentry/core/SentryOptions.java 78.2% <50%> (ø) 38 <2> (?)
...n/java/io/sentry/core/SentryStackTraceFactory.java 93.1% <88.88%> (ø) 11 <8> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460dbd3...65c21e1. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 606861b into master Oct 30, 2019
@bruno-garcia bruno-garcia deleted the feat/in_app_prefix branch October 30, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants