Skip to content

ref: Use sourcemap debugid features #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loewenheim merged 2 commits into from
Jul 19, 2023
Merged

ref: Use sourcemap debugid features #1686

loewenheim merged 2 commits into from
Jul 19, 2023

Conversation

@loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Jul 18, 2023 •
edited
Loading

Blocked by getting getsentry/rust-sourcemap#66 released.

This updates the sourcemap dependency to 6.3.0 so that we can use the new debug id features. Specifically:

  1. Rewriting sourcemaps leaves the debug id alone.
  2. Adding a debug id to a sourcemap doesn't require manual JSON parsing anymore.

@loewenheim loewenheim mentioned this pull request Jul 18, 2023
Closed
@loewenheim loewenheim marked this pull request as ready for review July 19, 2023 11:58
@loewenheim loewenheim self-assigned this Jul 19, 2023
@loewenheim loewenheim changed the title WIP: ref: Use sourcemap debugid features ref: Use sourcemap debugid features Jul 19, 2023
@loewenheim loewenheim merged commit c62f045 into master Jul 19, 2023
@loewenheim loewenheim deleted the ref/sourcemap-debugid branch July 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@loewenheim loewenheim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loewenheim @kamilogorek