Skip to content

feat: Adds breadcrumb.origin field #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 13 commits into from
Sep 26, 2024
Merged

feat: Adds breadcrumb.origin field #4358

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bb67cef
Adds breadcrumb.origin field
antonis Sep 20, 2024
d084b2b
Adds changelog
antonis Sep 20, 2024
9dcf512
Merge branch 'main' into antonis-add-breadrumb-origin
antonis Sep 23, 2024
98ee079
Moves changelog in the unreleased section
antonis Sep 23, 2024
5ea6526
Adds nil equality test case
antonis Sep 23, 2024
77cc812
Adds test case validating inequality if the breadcrumb origin is diff…
antonis Sep 24, 2024
ca96963
Merge branch 'main' into antonis-add-breadrumb-origin
antonis Sep 24, 2024
fcfbff2
Fixes broken test
antonis Sep 24, 2024
77b6372
Use nullability annotation for origin
antonis Sep 24, 2024
f03ae61
Format code
getsentry-bot Sep 24, 2024
c2f49e0
Updates nullable field declarations to use annotations
antonis Sep 24, 2024
2081760
Merge branch 'main' into antonis-add-breadrumb-origin
antonis Sep 25, 2024
5da364f
Makes origin field private
antonis Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updates nullable field declarations to use annotations
  • Loading branch information
@antonis
antonis committed Sep 24, 2024
commit c2f49e080b3e1a4470540dd5e79b8ab9df8cb40d
8 changes: 4 additions & 4 deletions Sources/Sentry/Public/SentryBreadcrumb.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ NS_SWIFT_NAME(Breadcrumb)
/**
* @c NSDate when the breadcrumb happened
*/
@property (nonatomic, strong) NSDate *_Nullable timestamp;
@property (nonatomic, strong, nullable) NSDate *timestamp;

/**
* Type of breadcrumb, can be e.g.: http, empty, user, navigation
* This will be used as icon of the breadcrumb
*/
@property (nonatomic, copy) NSString *_Nullable type;
@property (nonatomic, copy, nullable) NSString *type;

/**
* Origin of the breadcrumb that is used to identify source of the breadcrumb
Expand All @@ -43,12 +43,12 @@ NS_SWIFT_NAME(Breadcrumb)
/**
* Message for the breadcrumb
*/
@property (nonatomic, copy) NSString *_Nullable message;
@property (nonatomic, copy, nullable) NSString *message;

/**
* Arbitrary additional data that will be sent with the breadcrumb
*/
@property (nonatomic, strong) NSDictionary<NSString *, id> *_Nullable data;
@property (nonatomic, strong, nullable) NSDictionary<NSString *, id> *data;

/**
* Initializer for @c SentryBreadcrumb
Expand Down