Skip to content

parse and report async gaps #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 3 commits into from
Aug 7, 2017
Merged

parse and report async gaps #1

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64b6154
parse and report async gaps
yjbanov Aug 2, 2017
2e1a698
address comments
yjbanov Aug 7, 2017
c01562e
dartfmt
yjbanov Aug 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
@yjbanov
yjbanov committed Aug 7, 2017
commit 2e1a69817b45105261e96eb4e604e9cf39c3fae0
3 changes: 1 addition & 2 deletions lib/src/stack_trace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ List<Map<String, dynamic>> encodeStackTrace(dynamic stackTrace) {
final List<Map<String, dynamic>> frames = <Map<String, dynamic>>[];
for (int t = 0; t < chain.traces.length; t += 1) {
Copy link

@cbracken cbracken Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not t++?

Copy link
Contributor Author

@yjbanov yjbanov Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Flutter style.

frames.addAll(chain.traces[t].frames.map(encodeStackTraceFrame));
if (t < chain.traces.length - 1) {
if (t < chain.traces.length - 1)
frames.add(asynchronousGapFrameJson);
}
}
return frames;
}
Expand Down