add a Message type to add a logEntry to Event #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart/lib/src/protocol/message.dart
Outdated
| } | ||
|
|
||
| @override | ||
| bool operator ==(Object other) => |
Member
There was a problem hiding this comment.
We haven't been implementing these jn thr protocol. Is it really worth it?
Contributor
Author
There was a problem hiding this comment.
Not really, I thought maybe it could in some tests, but the existing tests test the serialization equality, so I guess it's not necessary.
marandaneto
reviewed
Oct 12, 2020
marandaneto
reviewed
Oct 12, 2020
dart/lib/src/protocol/message.dart
Outdated
Comment on lines
27
to
37
| @override | ||
| bool operator ==(Object other) => | ||
| identical(this, other) || | ||
| other is Message && | ||
| runtimeType == other.runtimeType && | ||
| formatted == other.formatted && | ||
| message == other.message && | ||
| params == other.params; | ||
|
|
||
| @override | ||
| int get hashCode => formatted.hashCode ^ message.hashCode ^ params.hashCode; |
Contributor
There was a problem hiding this comment.
why do we need that if all the other protocols don't have it? unless we want to unit test references etc
Contributor
Author
There was a problem hiding this comment.
I thought about it, but as it's not done for now in the protocol, I removed them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add a new Message class
💡 Motivation and Context
The Message Interface carries a log message that describes an event or error. Optionally, it can carry a format string and structured parameters. This can help to group similar messages into the same issue. cf. https://develop.sentry.dev/sdk/event-payloads/message/
fix #100
💚 How did you test it?
I updated the existing tests to verify all the message properties are correctly serialized
📝 Checklist
🔮 Next steps