Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
turn OptionsConfiguration to a typedef
  • Loading branch information
rxlabz committed Oct 14, 2020
commit cf5cd5089f4acf0cd2b80b2b89567bd4805d831b
13 changes: 1 addition & 12 deletions dart/example/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Future<void> main(List<String> rawArgs) async {
}

final dsn = rawArgs.single;
Sentry.init(Options(dsn: dsn));
Sentry.init((options) => options.dsn = dsn);

print('\nReporting a complete event example: ');

Expand Down Expand Up @@ -64,14 +64,3 @@ Future<void> bar() async {
Future<void> baz() async {
throw StateError('This is a test error');
}

class Options implements OptionsConfiguration<SentryOptions> {
final String dsn;

Options({this.dsn});

@override
void configure(SentryOptions options) {
options.dsn = dsn;
}
}
13 changes: 5 additions & 8 deletions dart/lib/src/sentry.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,19 @@ import 'client.dart';
import 'protocol.dart';
import 'sentry_options.dart';

/// Configuration options callback
typedef OptionsConfiguration = void Function(SentryOptions);

/// Sentry SDK main entry point
///
class Sentry {
static SentryClient _client;

Sentry._();

static void init(OptionsConfiguration<SentryOptions> optionsConfiguration) {
static void init(OptionsConfiguration optionsConfiguration) {
final options = SentryOptions();
optionsConfiguration.configure(options);
optionsConfiguration(options);
_client = SentryClient(
dsn: options.dsn,
environment: options.environment,
Expand Down Expand Up @@ -49,9 +52,3 @@ class Sentry {
@visibleForTesting
static void initClient(SentryClient client) => _client = client;
}

/// Configuration options callback
abstract class OptionsConfiguration<T extends SentryOptions> {
///configure the options
void configure(T options);
}
18 changes: 2 additions & 16 deletions dart/test/sentry_test.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import 'package:mockito/mockito.dart';
import 'package:sentry/src/client.dart';
import 'package:sentry/src/protocol.dart';
import 'package:sentry/src/sentry.dart';
import 'package:sentry/src/sentry_options.dart';
import 'package:sentry/sentry.dart';
import 'package:test/test.dart';

void main() {
Expand All @@ -14,7 +11,7 @@ void main() {
final dns = 'https://[email protected]/1234567';

setUp(() {
Sentry.init(Options(dsn: dns));
Sentry.init((options) => options.dsn = dns);

client = MockSentryClient();
Sentry.initClient(client);
Expand All @@ -39,17 +36,6 @@ void main() {

class MockSentryClient extends Mock implements SentryClient {}

class Options implements OptionsConfiguration<SentryOptions> {
final String dsn;

Options({this.dsn});

@override
void configure(SentryOptions options) {
options.dsn = dsn;
}
}

final event = Event(
loggerName: 'main',
serverName: 'server.dart',
Expand Down