feat: add Scope class #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 13, 2020
|
|
||
| dev_dependencies: | ||
| mockito: ^4.1.2 | ||
| mockito: ^4.1.1 |
Contributor
Author
There was a problem hiding this comment.
because of null-safety, this is not working right thru the IDE, downgrading version made it to work
Closed
marandaneto
commented
Oct 13, 2020
marandaneto
commented
Oct 13, 2020
marandaneto
commented
Oct 13, 2020
marandaneto
commented
Oct 14, 2020
Comment on lines
+9
to
+15
| SeverityLevel _level; | ||
|
|
||
| SeverityLevel get level => _level; | ||
|
|
||
| set level(SeverityLevel level) { | ||
| _level = level; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@bruno-garcia maybe we should add getters and setters only for List/Maps so they cannot mutate the whole thing?
https://dart.dev/guides/language/effective-dart/usage#dont-wrap-a-field-in-a-getter-and-setter-unnecessarily
Contributor
Author
|
merged into #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
add Scope class
💡 Motivation and Context
we'd like to have Scopes
💚 How did you test it?
📝 Checklist
🔮 Next steps
eventProcessors, Contexts, BeforeBreadcrumbCallback, Breadcrumb hint, clone