Skip to content

Conversation

@rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 14, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • define the sdkname based on the platform in the test
  • fix the GitHub action to run pub run test . instead of pub run test test/*

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@rxlabz rxlabz marked this pull request as ready for review October 14, 2020 09:45
@rxlabz rxlabz requested a review from marandaneto October 14, 2020 10:46
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxlabz rxlabz merged commit fe54d44 into main Oct 14, 2020
@rxlabz rxlabz deleted the fix/sdkname-test branch October 14, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants