feedbacks:

- add a scope comparaison method in tests
- move pkg:collection to dev_depencies
- changelog

CHANGELOG.md

@@ -20,7 +20,7 @@
 - new static API : Sentry.init(), Sentry.captureEvent() #108
 - expect a sdkName based on the test platform #105
 - Added Scope and Breadcrumb ring buffer #109
-- Added Hub ring buffer #113
+- Added Hub to SDK #113
 
 # `package:sentry` changelog
 

dart/lib/src/scope.dart

@@ -1,7 +1,5 @@
 import 'dart:collection';
 
-import 'package:collection/collection.dart';
-
 import 'protocol.dart';
 import 'sentry_options.dart';
 
@@ -157,28 +155,4 @@ class Scope {
 
     return clone;
   }
-
-  @override
-  bool operator ==(Object other) =>
-      identical(this, other) ||
-      other is Scope &&
-          runtimeType == other.runtimeType &&
-          _level == other.level &&
-          _transaction == other.transaction &&
-          _user == other.user &&
-          IterableEquality().equals(_fingerprint, other.fingerprint) &&
-          IterableEquality().equals(_breadcrumbs, other.breadcrumbs) &&
-          MapEquality().equals(_tags, other.tags) &&
-          MapEquality().equals(_extra, other.extra);
-
-  @override
-  int get hashCode =>
-      _level.hashCode ^
-      _transaction.hashCode ^
-      _user.hashCode ^
-      _fingerprint.hashCode ^
-      _breadcrumbs.hashCode ^
-      _tags.hashCode ^
-      _extra.hashCode ^
-      _options.hashCode;
 }

dart/pubspec.yaml

@@ -13,11 +13,11 @@ dependencies:
   meta: ^1.0.0
   stack_trace: ^1.0.0
   uuid: ^2.0.0
-  collection: ^1.14.13
 
 dev_dependencies:
   mockito: ^4.1.1
   pedantic: ^1.9.2
   test: ^1.15.4
   yaml: ^2.2.1
   test_coverage: ^0.4.1
+  collection: ^1.14.13

dart/test/event_test.dart

@@ -58,6 +58,8 @@ void main() {
 
       final error = StateError('test-error');
 
+      print('error.stackTrace ${error.stackTrace}');
+
       expect(
         Event(
           message: Message(
@@ -93,13 +95,6 @@ void main() {
           'exception': [
             {'type': 'StateError', 'value': 'Bad state: test-error'}
           ],
-          'stacktrace': {
-            'frames': encodeStackTrace(
-              error.stackTrace,
-              stackFrameFilter: null,
-              origin: null,
-            )
-          },
           'level': 'debug',
           'culprit': 'Professor Moriarty',
           'tags': {'a': 'b', 'c': 'd'},
@@ -122,7 +117,19 @@ void main() {
               },
             ]
           },
-        },
+        }..addAll(
+            error.stackTrace == null
+                ? {}
+                : {
+                    'stacktrace': {
+                      'frames': encodeStackTrace(
+                        error.stackTrace,
+                        stackFrameFilter: null,
+                        origin: null,
+                      )
+                    }
+                  },
+          ),
       );
     });
   });

dart/test/hub_test.dart

@@ -1,3 +1,4 @@
+import 'package:collection/collection.dart';
 import 'package:mockito/mockito.dart';
 import 'package:sentry/sentry.dart';
 import 'package:sentry/src/hub.dart';
@@ -6,6 +7,17 @@ import 'package:test/test.dart';
 import 'mocks.dart';
 
 void main() {
+  bool scopeEquals(Scope a, Scope b) {
+    return identical(a, b) ||
+        a.level == b.level &&
+            a.transaction == b.transaction &&
+            a.user == b.user &&
+            IterableEquality().equals(a.fingerprint, b.fingerprint) &&
+            IterableEquality().equals(a.breadcrumbs, b.breadcrumbs) &&
+            MapEquality().equals(a.tags, b.tags) &&
+            MapEquality().equals(a.extra, b.extra);
+  }
+
   group('Hub instantiation', () {
     test('should not instantiate without a sentryOptions', () {
       Hub hub;
@@ -35,13 +47,25 @@ void main() {
       hub.bindClient(client);
     });
 
-    test('should capture event', () {
-      hub.captureEvent(fakeEvent);
-      verify(
-        client.captureEvent(fakeEvent,
-            scope: Scope(options), stackFrameFilter: null),
-      ).called(1);
-    });
+    test(
+      'should capture event with the default scope',
+      () {
+        hub.captureEvent(fakeEvent);
+        expect(
+          scopeEquals(
+            verify(
+              client.captureEvent(
+                fakeEvent,
+                scope: captureAnyNamed('scope'),
+                stackFrameFilter: null,
+              ),
+            ).captured.first,
+            Scope(options),
+          ),
+          true,
+        );
+      },
+    );
 
     test('should capture exception', () {
       hub.captureException(fakeException);
@@ -76,16 +100,23 @@ void main() {
       });
       hub.captureEvent(fakeEvent);
 
-      verify(
-        client.captureEvent(
-          fakeEvent,
-          scope: Scope(SentryOptions(dsn: fakeDsn))
+      hub.captureEvent(fakeEvent);
+      expect(
+        scopeEquals(
+          verify(
+            client.captureEvent(
+              fakeEvent,
+              scope: captureAnyNamed('scope'),
+              stackFrameFilter: null,
+            ),
+          ).captured.first,
+          Scope(SentryOptions(dsn: fakeDsn))
             ..level = SeverityLevel.debug
             ..user = fakeUser
             ..fingerprint = ['1', '2'],
-          stackFrameFilter: null,
         ),
-      ).called(1);
+        true,
+      );
     });
   });
 
@@ -108,7 +139,7 @@ void main() {
       verify(
         client2.captureEvent(
           fakeEvent,
-          scope: Scope(options),
+          scope: anyNamed('scope'),
           stackFrameFilter: null,
         ),
       ).called(1);

dart/test/sentry_test.dart

@@ -23,7 +23,7 @@ void main() {
       verify(
         client.captureEvent(
           fakeEvent,
-          scope: Scope(SentryOptions(dsn: fakeDsn)) /*anyNamed('scope')*/,
+          scope: anyNamed('scope'),
           stackFrameFilter: null,
         ),
       ).called(1);