Skip to content

feat: sentry options #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 7 commits into from
Oct 20, 2020
Merged

feat: sentry options #116

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7728624
added principal options
marandaneto Oct 20, 2020
41858b1
Update dart/lib/src/sentry_options.dart
marandaneto Oct 20, 2020
e51f709
fix
marandaneto Oct 20, 2020
243274a
Merge branch 'feat/sentry_options' of github.com:getsentry/sentry-dar…
marandaneto Oct 20, 2020
f769945
changelog
marandaneto Oct 20, 2020
490c735
remove logger from ctor
marandaneto Oct 20, 2020
581d165
rename sentry level and do level comparison in diagnostic level
marandaneto Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@marandaneto
marandaneto committed Oct 20, 2020
commit e51f7090e0037b2f411e3514f2e046d8f30d7a5e
3 changes: 1 addition & 2 deletions dart/lib/src/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ class Sentry {
static void _setDefaultConfiguration(SentryOptions options) {
// TODO: check DSN nullability and empty

// TODO: find a way to know ifs no-op (&& options.logger is noOpLogger)
if (options.debug) {
if (options.debug && options.logger == noOpLogger) {
options.logger = dartLogger;
}
}
Expand Down