Ref: remove platform specific clients to use SentryClient (#152)

CHANGELOG.md

@@ -47,6 +47,7 @@
 - update the Dart sdk constraint
 - fix : throws on invalid dsn
 - GH Action ( CI ) run test on vm and on browser
+- ref: remove SentryBrowserClient & SentryIOClient, all platform can use SentryClient 
 - fix: example_web pubspec
 
 # `package:sentry` changelog

dart/lib/src/sentry_client.dart

@@ -3,30 +3,22 @@ import 'dart:math';
 
 import 'protocol.dart';
 import 'scope.dart';
-import 'sentry_client_stub.dart'
-    if (dart.library.html) 'sentry_browser_client.dart'
-    if (dart.library.io) 'sentry_io_client.dart';
 import 'sentry_options.dart';
 import 'transport/http_transport.dart';
 import 'transport/noop_transport.dart';
 import 'version.dart';
 
 /// Logs crash reports and events to the Sentry.io service.
-abstract class SentryClient {
-  /// Creates a new platform appropriate client.
-  ///
-  /// Creates an `SentryIOClient` if `dart:io` is available and a `SentryBrowserClient` if
-  /// `dart:html` is available, otherwise it will throw an unsupported error.
-  factory SentryClient(SentryOptions options) => createSentryClient(options);
-
-  SentryClient.base(this._options, {String origin}) {
+class SentryClient {
+  /// Instantiates a client using [SentryOptions]
+  SentryClient(SentryOptions options) : _options = options {
     _random = _options.sampleRate == null ? null : Random();
     if (_options.transport is NoOpTransport) {
-      _options.transport = HttpTransport(options: _options, origin: origin);
+      _options.transport = HttpTransport(options: _options);
     }
   }
 
-  SentryOptions _options;
+  final SentryOptions _options;
 
   Random _random;
 

dart/lib/src/transport/http_transport.dart

@@ -7,6 +7,7 @@ import '../protocol.dart';
 import '../sentry_options.dart';
 import '../utils.dart';
 import 'noop_encode.dart' if (dart.library.io) 'encode.dart';
+import 'noop_origin.dart' if (dart.library.html) 'origin.dart';
 import 'transport.dart';
 
 /// A transport is in charge of sending the event to the Sentry server.
@@ -15,16 +16,12 @@ class HttpTransport implements Transport {
 
   final Dsn _dsn;
 
-  /// Use for browser stacktrace
-  final String _origin;
-
   CredentialBuilder _credentialBuilder;
 
   final Map<String, String> _headers;
 
-  HttpTransport({@required SentryOptions options, String origin})
+  HttpTransport({@required SentryOptions options})
       : _options = options,
-        _origin = origin,
         _dsn = Dsn.parse(options.dsn),
         _headers = _buildHeaders(sdkIdentifier: options.sdk.identifier) {
     _credentialBuilder = CredentialBuilder(
@@ -36,7 +33,7 @@ class HttpTransport implements Transport {
 
   @override
   Future<SentryId> send(SentryEvent event) async {
-    final data = event.toJson(origin: _origin);
+    final data = event.toJson(origin: eventOrigin);
 
     final body = _bodyEncoder(
       data,

dart/lib/src/transport/noop_origin.dart

@@ -0,0 +1 @@
+String eventOrigin;

dart/lib/src/transport/origin.dart

@@ -0,0 +1,3 @@
+import 'dart:html';
+
+String get eventOrigin => '${window.location.origin}/';

dart/test/sentry_browser_test.dart

@@ -2,19 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 @TestOn('browser')
-import 'package:sentry/browser.dart';
-import 'package:sentry/sentry.dart';
 import 'package:test/test.dart';
 
 import 'test_utils.dart';
 
 void main() {
-  group('SentryBrowserClient', () {
-    test('SentryClient constructor build browser client', () {
-      final client = SentryClient(SentryOptions(dsn: testDsn));
-      expect(client is SentryBrowserClient, isTrue);
-    });
-
-    runTest(isWeb: true);
-  });
+  runTest(isWeb: true);
 }

dart/test/sentry_io_client_test.dart

@@ -4,19 +4,10 @@
 @TestOn('vm')
 import 'dart:io';
 
-import 'package:sentry/sentry.dart';
-import 'package:sentry/src/sentry_io_client.dart';
 import 'package:test/test.dart';
 
 import 'test_utils.dart';
 
 void main() {
-  group(SentryIOClient, () {
-    test('SentryClient constructor build io client', () {
-      final client = SentryClient(SentryOptions(dsn: testDsn));
-      expect(client is SentryIOClient, isTrue);
-    });
-
-    runTest(gzip: gzip);
-  });
+  runTest(gzip: gzip);
 }