Enha: Exceptions not handled by user code should be unhandled: true
#1186
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1186 +/- ##
=========================================
Coverage ? 76.27%
=========================================
Files ? 11
Lines ? 333
Branches ? 0
=========================================
Hits ? 254
Misses ? 79
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
denrase
requested review from
brustolin,
krystofwoldrich and
marandaneto
as code owners
|
@denrase please check if the |
…hould-be-unhandled-true
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CHANGELOG.md
Outdated
|
|
||
| ### Enhancements | ||
|
|
||
| - Enha: Exceptions not handled by user code should be `unhandled: true` #1186 ([#1186](https://github.com/getsentry/sentry-dart/pull/1186)) |
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 7.0.0.
Consider moving the entry to the## Unreleasedsection, please.
|
@marandaneto Also removing them from unhandled but not crashing event mechanisms that we create in the SDK. |
Not sure I understand this comment, mind elaborating? Another pending point if not done yet, we have to test the integration with the Native SDKs and the release health feature. |
|
@marandaneto Sorry, hope this is a better explanation.
Ah sure, i was referring to the documentation of why we introduced the breadcrumb removal.
My assumption is that we still need to remove the breadcrumbs in those new instances where we have set the value to I have added unit tests that cover this new behaviour. |
…uld-be-unhandled-true
…hould-be-unhandled-true
| // final hasOnlyHandledMechanism = mechanisms | ||
| // .every((e) => (e.handled ?? true)); | ||
|
|
||
| // if (hasNoMechanism || hasOnlyHandledMechanism) { |
There was a problem hiding this comment.
@marandaneto Is this final or are you still in implementation process?
There was a problem hiding this comment.
I was just testing and found out that this has to be fixed, hence the comments.
|
@marandaneto Raised an issue on the cocoa side. |
Thanks, let's pause this PR for a bit, I'm talking to the Apple folks about this issue, this is a blocker for us. |
|
@denrase this is unblocked now, getsentry/sentry-cocoa#2593 |
|
Closing in favor of #1535 |
📜 Description
Closes #456
Always set to unhandled, as there are no handlers provided:
Set to unhandled if there are no user provided handlers:
Verified in tests that handled is null on the mechanism. Technically those should also be unhandled, as users are not manually calling the Sentry SDK, but failed requests are something so common and should probably not be unhandled?
💚 How did you test it?
Added unit tests.
📝 Checklist
🔮 Next steps
Review every individually created mechanism if the
handledflag makes sense.