feat: before breadcrumb and scope ref #122
Conversation
marandaneto
changed the title
| clone.addBreadcrumb(breadcrumb); | ||
| } | ||
|
|
||
| for (final eventProcessor in _eventProcessors) { |
There was a problem hiding this comment.
Since we're in the class, what about a private constructor or factory method that takes all fields as named args?
Then we could just clone all lists etc like Scope({eventProcessors = [...this.eventprocessors]) and avoid tall these for
There was a problem hiding this comment.
mm yeah but rethinking this right now, maybe it'd make sense to just do a copyWith and follow the convention? tbh I just added the missing field in the existent method, I will check whats the state of the art for cloning objects on Dart.
Factory is public afaik, but a private ctor would work as well
There was a problem hiding this comment.
https://pub.dev/documentation/copyable/latest/#examples
using the copyable interface seems to be the standard
There was a problem hiding this comment.
I will add this as a task on our project, so I can merge this now
There was a problem hiding this comment.
copyWith is probably the "most standard way" ( used a lot in Flutter source code, and in https://pub.dev/packages/freezed, a popular immutable package)
📢 Type of change
📜 Description
feat: before breadcrumb and scope ref
💡 Motivation and Context
One should be able to filter breadcrumbs on before breadcrumb callback and also add event processors to the scope
💚 How did you test it?
📝 Checklist
🔮 Next steps
Contexts is still missing