-
-
Notifications
You must be signed in to change notification settings - Fork 277
Ref: Error Cause Extractor Updates #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 90.11% // Head: 90.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1236 +/- ##
==========================================
+ Coverage 90.11% 90.21% +0.10%
==========================================
Files 113 124 +11
Lines 3510 3691 +181
==========================================
+ Hits 3163 3330 +167
- Misses 347 361 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yeah that's true but usually, it is the cause. |
📜 Description
Adds remaining feedback from #1198
@marandaneto After documenting the classes, I'm not sure abaut the
Causein the naming. Technically an inner exception does not have to be the cause of an exception i guess. So maybe we should replaceCausewithInner? WDYT?💚 How did you test it?
Tests
📝 Checklist