Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 22, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Ref: Hint is passed across Sentry static class, Hub and Client

💡 Motivation and Context

EventProcessors support Hint, in order to support that, Sentry static class, hub and Client should be able to get it

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 22, 2020 08:11
@marandaneto marandaneto requested a review from rxlabz October 22, 2020 08:11
@marandaneto marandaneto changed the title ref/hint Ref: Hint is passed across Sentry static class, Hub and Client Oct 22, 2020
/// Reports an [event] to Sentry.io.
Future<SentryId> captureEvent(
SentryEvent event, {
StackFrameFilter stackFrameFilter,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (beside missing trailing comma :) )

@marandaneto marandaneto merged commit 2cc1d78 into feature/unified-api Oct 22, 2020
@marandaneto marandaneto deleted the ref/hint branch October 22, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants