Skip to content

Implement loadStructuredBinaryData from updated AssetBundle #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 4 commits into from Feb 28, 2023
Merged

Implement loadStructuredBinaryData from updated AssetBundle #1272

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
634d450
implement loadStructuredBinaryData
arnemolland Feb 7, 2023
5e79e10
Emulate `loadStructuredBinaryData` on all versions
arnemolland Feb 27, 2023
3ebefd0
Revert "Emulate `loadStructuredBinaryData` on all versions"
arnemolland Feb 28, 2023
0b1a611
Add TestAssetBundle override
arnemolland Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add TestAssetBundle override
  • Loading branch information
@arnemolland
arnemolland committed Feb 28, 2023
commit 0b1a61147dbfc05d43ee7ee4d23c84e55a258dc9
15 changes: 15 additions & 0 deletions flutter/test/sentry_asset_bundle_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// ignore_for_file: invalid_use_of_internal_member
// The lint above is okay, because we're using another Sentry package
import 'dart:async';
import 'dart:convert';
// backcompatibility for Flutter < 3.3
// ignore: unnecessary_import
Expand Down Expand Up @@ -545,6 +546,20 @@ class TestAssetBundle extends CachingAssetBundle {
bool throwException = false;
String? evictKey;

@override
// ignore: override_on_non_overriding_member
Future<T> loadStructuredBinaryData<T>(
String key, FutureOr<T> Function(ByteData data) parser) async {
if (throwException) {
throw Exception('exception thrown for testing purposes');
}
if (key == _testFileName) {
return parser(ByteData.view(
Uint8List.fromList(utf8.encode('Hello World!')).buffer));
}
return parser(ByteData(0));
}

@override
Future<ByteData> load(String key) async {
if (throwException) {
Expand Down