Skip to content

Fix: execute Integrations on Hub creation #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 4 commits into from
Oct 26, 2020
Merged

Fix: execute Integrations on Hub creation #136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae6ea2c
fix: execute integrations on hub creation
marandaneto Oct 26, 2020
dc5e67b
import async
marandaneto Oct 26, 2020
3b861b7
add test
marandaneto Oct 26, 2020
0a39ada
Merge branch 'feature/unified-api' into fix/execute-integrations
marandaneto Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@marandaneto
marandaneto committed Oct 26, 2020
commit 3b861b7841c38f87d723c17b8f4ebdd39fd7d86f
11 changes: 5 additions & 6 deletions dart/test/hub_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,12 @@ void main() {
});

test('should install integrations', () {
var called = false;
void integration(Hub hub, SentryOptions options) => called = true;
options.addIntegration(integration);
final hub = Hub(options);
client = MockSentryClient();
hub.bindClient(client);
// TODO: assert that integration(hub, options) has been invoked
Hub(options);

expect(called, true);
});
});

Expand Down Expand Up @@ -192,5 +193,3 @@ void main() {
// could we set [hub.stack] as @visibleForTesting ?
});
}

void integration(Hub hub, SentryOptions options) {}