Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: NoOp encode for web
  • Loading branch information
marandaneto committed Oct 26, 2020
commit f84e7a3acfc98c74afb9a8116c6d23adc66e8cc8
17 changes: 0 additions & 17 deletions dart/lib/src/transport/body_encoder.dart

This file was deleted.

12 changes: 0 additions & 12 deletions dart/lib/src/transport/body_encoder_browser.dart

This file was deleted.

7 changes: 7 additions & 0 deletions dart/lib/src/transport/encode.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import 'dart:io';

/// Encodes the body using Gzip compression
void compressBody(List<int> body, Map<String, String> headers) {
headers['Content-Encoding'] = 'gzip';
body = gzip.encode(body);
}
2 changes: 2 additions & 0 deletions dart/lib/src/transport/noop_encode.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/// gzip compression is not available on browser
void compressBody(List<int> body, Map<String, String> headers) {}
24 changes: 17 additions & 7 deletions dart/lib/src/transport/transport.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@ import 'package:sentry/src/utils.dart';

import '../protocol.dart';
import '../sentry_options.dart';
import 'body_encoder_browser.dart' if (dart.library.io) 'body_encoder.dart';
import 'noop_encode.dart' if (dart.library.io) 'encode.dart';

typedef BodyEncoder = List<int> Function(
Map<String, dynamic> data,
Map<String, String> headers, {
bool compressPayload,
});
typedef BodyEncoder = Function(List<int> body, Map<String, String> headers);

/// A transport is in charge of sending the event to the Sentry server.
class Transport {
Expand Down Expand Up @@ -43,7 +39,7 @@ class Transport {
Future<SentryId> send(SentryEvent event) async {
final data = event.toJson(origin: _origin);

final body = bodyEncoder(
final body = _bodyEncoder(
data,
_headers,
compressPayload: _options.compressPayload,
Expand All @@ -62,6 +58,20 @@ class Transport {
final eventId = json.decode(response.body)['id'];
return eventId != null ? SentryId.fromId(eventId) : SentryId.empty();
}

List<int> _bodyEncoder(
Map<String, dynamic> data,
Map<String, String> headers, {
bool compressPayload,
}) {
// [SentryIOClient] implement gzip compression
// gzip compression is not available on browser
var body = utf8.encode(json.encode(data));
if (compressPayload) {
compressBody(body, headers);
}
return body;
}
}

class CredentialBuilder {
Expand Down