Skip to content

Fix: Breadcrumb data should accept serializable types and not only String values #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 3 commits into from
Oct 26, 2020
Merged

Fix: Breadcrumb data should accept serializable types and not only String values #139

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87327bd
Fix: Breadcrumb data should accept serialziable types and not only St…
marandaneto Oct 26, 2020
bf34927
changelog
marandaneto Oct 26, 2020
20ed605
Update CHANGELOG.md
marandaneto Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- Ref: execute before send callback
- Feat: add lastEventId to the Sentry static API
- Feat: addBreadcrumb on Static API
- Fix: Breadcrumb data should accept serialziable types and not only String values

# `package:sentry` changelog

Expand Down
4 changes: 2 additions & 2 deletions dart/lib/src/protocol/breadcrumb.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class Breadcrumb {
/// See also:
///
/// * https://docs.sentry.io/development/sdk-dev/event-payloads/breadcrumbs/#breadcrumb-types
final Map<String, String> data;
final Map<String, dynamic> data;

/// Severity of the breadcrumb.
///
Expand Down Expand Up @@ -85,7 +85,7 @@ class Breadcrumb {
json['category'] = category;
}
if (data != null && data.isNotEmpty) {
json['data'] = Map.of(data);
json['data'] = data;
}
if (level != null) {
json['level'] = level.name;
Expand Down