Skip to content

Fixed "Culprit" recording in Sentry #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 4 commits into from
Apr 26, 2018
Merged

Fixed "Culprit" recording in Sentry #14

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe98ed2
Fix stack-trace frame ordering. In order for `Culprit` to be logged c…
slightfoot Feb 15, 2018
87d5803
Updated tests.
slightfoot Apr 13, 2018
e92a0c6
Fix stack-frame tests.
slightfoot Apr 13, 2018
220f6b3
dartfmt over test/sentry_test.dart
slightfoot Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix stack-trace frame ordering. In order for Culprit to be logged c… 
…orrectly it should have the latest frame at th top.
  • Loading branch information
@slightfoot
slightfoot committed Apr 26, 2018
commit fe98ed2992df426521768d69e191b1053f23f388
2 changes: 1 addition & 1 deletion lib/src/stack_trace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ List<Map<String, dynamic>> encodeStackTrace(dynamic stackTrace) {
frames.addAll(chain.traces[t].frames.map(encodeStackTraceFrame));
if (t < chain.traces.length - 1) frames.add(asynchronousGapFrameJson);
}
return frames;
return frames.reversed.toList();
}

Map<String, dynamic> encodeStackTraceFrame(Frame frame) {
Expand Down