Skip to content

Ref/prepare event & scope.applyToEvent #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxlabz merged 13 commits into from
Oct 27, 2020
Merged

Ref/prepare event & scope.applyToEvent #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cf41f95
add sentryClient._prepareEvent && scope.applyToEvent(event,hint)
rxlabz Oct 27, 2020
b30e8ed
changelog
rxlabz Oct 27, 2020
8d5c670
wording
rxlabz Oct 27, 2020
4b79722
doc
rxlabz Oct 27, 2020
1e17186
log null scope
rxlabz Oct 27, 2020
40b947e
update only event empty properties on prepareEvent()
rxlabz Oct 27, 2020
aeb42dc
typo
rxlabz Oct 27, 2020
2066a42
refacto scope.applyToEvent
rxlabz Oct 27, 2020
ee6a400
Merge branch 'ref/prepare-event' of github.com:getsentry/sentry-dart …
rxlabz Oct 27, 2020
74e54e1
set a default environment
rxlabz Oct 27, 2020
8a9f948
apply scope tags and extra only if not empty
rxlabz Oct 27, 2020
72b7a2f
set the default event.sdk in client._prepareEvent
rxlabz Oct 27, 2020
cce06d7
set the default sdk in SentryOptions
rxlabz Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
set the default sdk in SentryOptions
  • Loading branch information
@rxlabz
rxlabz committed Oct 27, 2020
commit cce06d72a983da03d491be3e5c57a8c377c8b45a
2 changes: 1 addition & 1 deletion dart/lib/src/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ abstract class SentryClient {
environment:
event.environment ?? _options.environment ?? defaultEnvironment,
release: event.release ?? _options.release,
sdk: event.sdk ?? Sdk(name: sdkName, version: sdkVersion),
sdk: event.sdk ?? _options.sdk,
platform: event.platform ?? sdkPlatform,
);

Expand Down
9 changes: 7 additions & 2 deletions dart/lib/src/sentry_options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ class SentryOptions {
/// Sets the release. SDK will try to automatically configure a release out of the box
String release;

// TODO: probably its part of environmentAttributes
/// Sets the environment. This string is freeform and not set by default. A release can be
/// associated with more than one environment to separate them in the UI Think staging vs prod or
/// similar.
Expand Down Expand Up @@ -139,8 +138,14 @@ class SentryOptions {
/// The server name used in the Sentry messages.
String serverName;

Sdk _sdk = Sdk(name: sdkName, version: sdkVersion);

/// Sdk object that contains the Sentry Client Name and its version
Sdk sdk;
Sdk get sdk => _sdk;

set sdk(Sdk sdk) {
_sdk = sdk ?? _sdk;
}

// TODO: Scope observers, enableScopeSync

Expand Down