Skip to content

Conversation

@rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 27, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Stricter analysis options :

  • prefer relative path
  • error missing @required argument
    ...

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@rxlabz rxlabz changed the title lint : prefer relative imports and show error when a @required argume… chore : analysis options Oct 27, 2020
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this, LGTM

@marandaneto marandaneto merged commit a0bb939 into feature/unified-api Oct 27, 2020
@marandaneto marandaneto deleted the chore/analysis-options branch October 27, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants