Skip to content

ref: Unified API code review #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marandaneto merged 1 commit into from
Oct 28, 2020
Merged

ref: Unified API code review #144

marandaneto merged 1 commit into from
Oct 28, 2020

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 28, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

ref: Unified API code review

💡 Motivation and Context

#117 code review + improvements

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to feature/unified-api October 28, 2020 07:20
@marandaneto marandaneto changed the title fix/unified api code review ref: Unified API code review Oct 28, 2020
@marandaneto marandaneto requested a review from rxlabz October 28, 2020 07:21
rxlabz
rxlabz approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit a7ca364 into feature/unified-api Oct 28, 2020
@marandaneto marandaneto deleted the fix/unified-api-code-review branch October 28, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

1 more reviewer

@rxlabz rxlabz rxlabz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marandaneto @rxlabz