Ref : remove dsn from Transport public API

CHANGELOG.md

@@ -43,6 +43,7 @@
 - Ref: rename sdk files accordely to their content
 - chore: new analysis options rules
 - Ref: rename the `throwable` argument name to `exception` in `captureEvents(...)`
+- Ref : remove dsn from Transport public Api
 
 # `package:sentry` changelog
 

dart/lib/src/transport/http_transport.dart

@@ -13,8 +13,7 @@ import 'transport.dart';
 class HttpTransport implements Transport {
   final SentryOptions _options;
 
-  @visibleForTesting
-  final Dsn dsn;
+  final Dsn _dsn;
 
   /// Use for browser stacktrace
   final String _origin;
@@ -26,7 +25,7 @@ class HttpTransport implements Transport {
   HttpTransport({@required SentryOptions options, String origin})
       : _options = options,
         _origin = origin,
-        dsn = Dsn.parse(options.dsn),
+        _dsn = Dsn.parse(options.dsn),
         _headers = _buildHeaders(sdkIdentifier: options.sdk.identifier) {
     _credentialBuilder = CredentialBuilder(
       dsn: Dsn.parse(options.dsn),
@@ -46,7 +45,7 @@ class HttpTransport implements Transport {
     );
 
     final response = await _options.httpClient.post(
-      dsn.postUri,
+      _dsn.postUri,
       headers: _credentialBuilder.configure(_headers),
       body: body,
     );

dart/test/test_utils.dart

@@ -8,7 +8,6 @@ import 'dart:convert';
 import 'package:http/http.dart';
 import 'package:http/testing.dart';
 import 'package:sentry/sentry.dart';
-import 'package:sentry/src/transport/http_transport.dart';
 import 'package:test/test.dart';
 
 const String testDsn = 'https://public:[email protected]/1';
@@ -89,8 +88,8 @@ Future testCaptureException(
     expect('$sentryId', 'testeventid');
   }
 
-  final transport = options.transport as HttpTransport;
-  expect(postUri, transport.dsn.postUri);
+  final dsn = Dsn.parse(options.dsn);
+  expect(postUri, dsn.postUri);
 
   testHeaders(
     headers,
@@ -181,66 +180,66 @@ void runTest({Codec<List<int>, List<int>> gzip, bool isWeb = false}) {
     final options = SentryOptions(dsn: testDsn);
     final client = SentryClient(options);
 
-    final transport = options.transport as HttpTransport;
+    final dsn = Dsn.parse(options.dsn);
 
-    expect(transport.dsn.uri, Uri.parse(testDsn));
+    expect(dsn.uri, Uri.parse(testDsn));
     expect(
-      transport.dsn.postUri,
+      dsn.postUri,
       'https://sentry.example.com/api/1/store/',
     );
-    expect(transport.dsn.publicKey, 'public');
-    expect(transport.dsn.secretKey, 'secret');
-    expect(transport.dsn.projectId, '1');
+    expect(dsn.publicKey, 'public');
+    expect(dsn.secretKey, 'secret');
+    expect(dsn.projectId, '1');
     await client.close();
   });
 
   test('can parse DSN without secret', () async {
     final options = SentryOptions(dsn: _testDsnWithoutSecret);
     final client = SentryClient(options);
 
-    final transport = options.transport as HttpTransport;
+    final dsn = Dsn.parse(options.dsn);
 
-    expect(transport.dsn.uri, Uri.parse(_testDsnWithoutSecret));
+    expect(dsn.uri, Uri.parse(_testDsnWithoutSecret));
     expect(
-      transport.dsn.postUri,
+      dsn.postUri,
       'https://sentry.example.com/api/1/store/',
     );
-    expect(transport.dsn.publicKey, 'public');
-    expect(transport.dsn.secretKey, null);
-    expect(transport.dsn.projectId, '1');
+    expect(dsn.publicKey, 'public');
+    expect(dsn.secretKey, null);
+    expect(dsn.projectId, '1');
     await client.close();
   });
 
   test('can parse DSN with path', () async {
     final options = SentryOptions(dsn: _testDsnWithPath);
     final client = SentryClient(options);
 
-    final transport = options.transport as HttpTransport;
+    final dsn = Dsn.parse(options.dsn);
 
-    expect(transport.dsn.uri, Uri.parse(_testDsnWithPath));
+    expect(dsn.uri, Uri.parse(_testDsnWithPath));
     expect(
-      transport.dsn.postUri,
+      dsn.postUri,
       'https://sentry.example.com/path/api/1/store/',
     );
-    expect(transport.dsn.publicKey, 'public');
-    expect(transport.dsn.secretKey, 'secret');
-    expect(transport.dsn.projectId, '1');
+    expect(dsn.publicKey, 'public');
+    expect(dsn.secretKey, 'secret');
+    expect(dsn.projectId, '1');
     await client.close();
   });
   test('can parse DSN with port', () async {
     final options = SentryOptions(dsn: _testDsnWithPort);
     final client = SentryClient(options);
 
-    final transport = options.transport as HttpTransport;
+    final dsn = Dsn.parse(options.dsn);
 
-    expect(transport.dsn.uri, Uri.parse(_testDsnWithPort));
+    expect(dsn.uri, Uri.parse(_testDsnWithPort));
     expect(
-      transport.dsn.postUri,
+      dsn.postUri,
       'https://sentry.example.com:8888/api/1/store/',
     );
-    expect(transport.dsn.publicKey, 'public');
-    expect(transport.dsn.secretKey, 'secret');
-    expect(transport.dsn.projectId, '1');
+    expect(dsn.publicKey, 'public');
+    expect(dsn.secretKey, 'secret');
+    expect(dsn.projectId, '1');
     await client.close();
   });
   test('sends client auth header without secret', () async {