Skip to content

Fix the pubspec Dart Sdk constraint #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rxlabz merged 3 commits into from
Oct 28, 2020
Merged

Fix the pubspec Dart Sdk constraint #146

rxlabz merged 3 commits into from
Oct 28, 2020

Conversation

@rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 28, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

Package validation found the following error:
* ^ version constraints aren't allowed for SDK constraints since older versions of pub don't support them.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxlabz rxlabz merged commit 209f18a into feature/unified-api Oct 28, 2020
@rxlabz rxlabz deleted the fix/sdk-constraint branch October 28, 2020 09:15
@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 28, 2020

Oh jeez, how old are these pub clients? 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

1 more reviewer

@marandaneto marandaneto marandaneto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxlabz @bruno-garcia @marandaneto