Skip to content

Improve SentryException#value, remove stringified stack trace #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 18 commits into from
May 31, 2023
Merged

Improve SentryException#value, remove stringified stack trace #1470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
83906b3
add stack trace detection
denrase May 22, 2023
f3bc9f4
dont set value if it is a stack trace
denrase May 22, 2023
60d41d3
add changelog entry
denrase May 22, 2023
3a3d303
replace stack trace lines
denrase May 22, 2023
4d1ac36
change to static function
denrase May 22, 2023
e9bf9bd
simple replace for stack trace string
denrase May 23, 2023
4f09714
Merge branch 'main' into feat/improve-sentry-exception-value
denrase May 23, 2023
3137954
fix cl
denrase May 23, 2023
2d1056f
change test name
denrase May 23, 2023
b2e6faa
Merge branch 'main' into feat/improve-sentry-exception-value
denrase May 23, 2023
25123d1
Merge branch 'main' into feat/improve-sentry-exception-value
denrase May 30, 2023
ad2d602
no empty value
denrase May 30, 2023
1eede7c
add newline in cl
denrase May 30, 2023
ae20cfb
format
denrase May 30, 2023
dd2a32b
remove debug code
denrase May 30, 2023
90d030e
use correct object
denrase May 30, 2023
b2a8c54
Merge branch 'main' into feat/improve-sentry-exception-value
denrase May 30, 2023
1d6a2cc
fix changelog
denrase May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
no empty value
  • Loading branch information
@denrase
denrase committed May 30, 2023
commit ad2d60268c6fd09764fffbaf7931f1d04820fd1c
2 changes: 1 addition & 1 deletion dart/lib/src/sentry_exception_factory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class SentryExceptionFactory {
// https://flutter.dev/docs/deployment/obfuscate#caveat
return SentryException(
type: (throwable.runtimeType).toString(),
value: value,
value: value.isNotEmpty ? value : null,
mechanism: mechanism,
stackTrace: sentryStackTrace,
throwable: throwable,
Expand Down
14 changes: 13 additions & 1 deletion dart/test/sentry_exception_factory_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,15 @@ void main() {

expect(sentryException.value, expected);
});

test('no empty value', () {
final stackTraceError = StackTraceError();
stackTraceError.prefix = "";
final sentryException = fixture.getSut().getSentryException(stackTraceError,
stackTrace: StackTraceErrorStackTrace());

expect(sentryException.value, isNull);
});
}

class CustomError extends Error {}
Expand All @@ -198,10 +207,13 @@ class CustomExceptionStackTraceExtractor
}

class StackTraceError extends Error {

var prefix = "NetworkError(type: NetworkErrorType.unknown, error: Instance of 'iH')";

@override
String toString() {
return '''
NetworkError(type: NetworkErrorType.unknown, error: Instance of 'iH')
$prefix

pid: 9437, tid: 10069, name 1.ui
os: android arch: arm64 comp: yes sim: no
Expand Down