Skip to content

unified fixes #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxlabz merged 8 commits into from
Oct 28, 2020
Merged

unified fixes #148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
805058b
remove an obsolete comment
rxlabz Oct 28, 2020
bdd4150
remove assertion : always test if uri.pathSegment is not empty
rxlabz Oct 28, 2020
f0e710e
parse the dsn only once
rxlabz Oct 28, 2020
6c48a70
changelog
rxlabz Oct 28, 2020
e5d41a3
catch Dsn.parse exceptions
rxlabz Oct 28, 2020
ea15547
try to parse the dsn on _setDefaultConfiguration
rxlabz Oct 28, 2020
59a2d7c
remove the default options.sdk assignment from clients
rxlabz Oct 28, 2020
594e7c0
fix docs
rxlabz Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to parse the dsn on _setDefaultConfiguration
  • Loading branch information
@rxlabz
rxlabz committed Oct 28, 2020
commit ea1554740ded5a7e3bb50aa9b84f791fad90490f
3 changes: 3 additions & 0 deletions dart/lib/src/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ class Sentry {
return false;
}

// try parsing the dsn
Dsn.parse(options.dsn);

// if logger os NoOp, let's set a logger that prints on the console
if (options.debug && options.logger == noOpLogger) {
options.logger = dartLogger;
Expand Down
8 changes: 1 addition & 7 deletions dart/lib/src/sentry_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,7 @@ abstract class SentryClient {
SentryClient.base(this._options, {String origin}) {
_random = _options.sampleRate == null ? null : Random();
if (_options.transport is NoOpTransport) {
try {
_options.transport = HttpTransport(options: _options, origin: origin);
} on ArgumentError catch (error) {
_options.logger(SentryLevel.error, '${error.message}');
} catch (err) {
_options.logger(SentryLevel.error, 'An exception occurred.');
}
_options.transport = HttpTransport(options: _options, origin: origin);
}
}

Expand Down