Skip to content

Mark exceptions not handled by user as handled: false #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 14 commits into from
Jul 27, 2023
Merged

Mark exceptions not handled by user as handled: false #1535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3a08510
change explicitly handled to unhandled
denrase Jun 27, 2023
4666874
add changlog entry
denrase Jun 27, 2023
c1e8d7a
update changelog
denrase Jun 27, 2023
2b34221
Merge branch 'main' into enha/user-unhandled
marandaneto Jul 14, 2023
a6cb7ab
bump sentry ios version
denrase Jul 17, 2023
db2b18e
Merge branch 'main' into enha/user-unhandled
denrase Jul 17, 2023
6f1f672
Merge branch 'main' into enha/user-unhandled
denrase Jul 24, 2023
33d0587
Add `appHangTimeoutInterval` to `SentryFlutterOptions` (#1568)
denrase Jul 25, 2023
3e33891
DioEventProcessor: Append http response body (#1557)
denrase Jul 26, 2023
816fdd2
release: 7.9.0
getsentry-bot Jul 26, 2023
6885737
fix formatting
marandaneto Jul 26, 2023
d783424
Merge branch 'release/7.9.0'
Jul 26, 2023
2bb6b56
Merge branch 'main' into enha/user-unhandled
marandaneto Jul 27, 2023
53f2304
fix
marandaneto Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
change explicitly handled to unhandled
  • Loading branch information
@denrase
denrase committed Jun 27, 2023
commit 3a085103cd4e1e834a1db14876b8d7192cf78587
4 changes: 2 additions & 2 deletions dart/lib/src/run_zoned_guarded_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class RunZonedGuardedIntegration extends Integration<SentryOptions> {
stackTrace: stackTrace,
);

// runZonedGuarded doesn't crash the App.
final mechanism = Mechanism(type: 'runZonedGuarded', handled: true);
// runZonedGuarded doesn't crash the app, but is not handled by the user.
final mechanism = Mechanism(type: 'runZonedGuarded', handled: false);
final throwableMechanism = ThrowableMechanism(mechanism, exception);

final event = SentryEvent(
Expand Down
5 changes: 3 additions & 2 deletions dart/lib/src/sentry_isolate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ class SentryIsolate {
stackTrace == null ? null : StackTrace.fromString(stackTrace),
);

// Isolate errors don't crash the App.
final mechanism = Mechanism(type: 'isolateError', handled: true);
// Isolate errors don't crash the app, but is not handled by the user.
final mechanism = Mechanism(type: 'isolateError', handled: false);
final throwableMechanism = ThrowableMechanism(mechanism, throwable);

final event = SentryEvent(
throwable: throwableMechanism,
level: SentryLevel.fatal,
Expand Down
7 changes: 2 additions & 5 deletions flutter/lib/src/integrations/flutter_error_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,8 @@ class FlutterErrorIntegration implements Integration<SentryFlutterOptions> {
stackTrace: errorDetails.stack,
);

// FlutterError doesn't crash the App.
final mechanism = Mechanism(
type: 'FlutterError',
handled: true,
);
// FlutterError doesn't crash the app, but is not handled by the user.
final mechanism = Mechanism(type: 'FlutterError', handled: false);
final throwableMechanism = ThrowableMechanism(mechanism, exception);

var event = SentryEvent(
Expand Down
6 changes: 3 additions & 3 deletions flutter/test/integrations/flutter_error_integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ void main() {

final throwableMechanism = event.throwableMechanism as ThrowableMechanism;
expect(throwableMechanism.mechanism.type, 'FlutterError');
expect(throwableMechanism.mechanism.handled, true);
expect(throwableMechanism.mechanism.handled, false);
expect(throwableMechanism.throwable, exception);

expect(event.contexts['flutter_error_details']['library'], 'sentry');
Expand Down Expand Up @@ -102,7 +102,7 @@ void main() {

final throwableMechanism = event.throwableMechanism as ThrowableMechanism;
expect(throwableMechanism.mechanism.type, 'FlutterError');
expect(throwableMechanism.mechanism.handled, true);
expect(throwableMechanism.mechanism.handled, false);

expect(event.contexts['flutter_error_details']['library'], 'sentry');
expect(event.contexts['flutter_error_details']['context'],
Expand All @@ -126,7 +126,7 @@ void main() {

final throwableMechanism = event.throwableMechanism as ThrowableMechanism;
expect(throwableMechanism.mechanism.type, 'FlutterError');
expect(throwableMechanism.mechanism.handled, true);
expect(throwableMechanism.mechanism.handled, false);
expect(throwableMechanism.mechanism.data['hint'], isNull);

expect(event.contexts['flutter_error_details'], isNull);
Expand Down