Skip to content

add contexts to scope and apply it #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxlabz merged 26 commits into from
Oct 30, 2020
Merged

add contexts to scope and apply it #154

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
94f416e
add contexts to scope and apply it
rxlabz Oct 29, 2020
82d23bf
fix lint
rxlabz Oct 29, 2020
d566896
add a scope.applyToEvent test
rxlabz Oct 29, 2020
e1451ac
update contexts.runtimes doc
rxlabz Oct 29, 2020
3bf0991
add clone methods
rxlabz Oct 29, 2020
13eceed
fix tests
rxlabz Oct 29, 2020
0b90df3
add a const `runtimes` key
rxlabz Oct 29, 2020
39352a7
use const keys
rxlabz Oct 29, 2020
262305a
remove TODOs
rxlabz Oct 29, 2020
f02bc2f
mapView type
rxlabz Oct 30, 2020
475ee9e
make setContexts argument non-optional
rxlabz Oct 30, 2020
d8e6991
force the contexts values type
rxlabz Oct 30, 2020
4e07e05
add scope.removeContexts
rxlabz Oct 30, 2020
00b5fba
add scope.setContexts conditions
rxlabz Oct 30, 2020
1a6af63
add Runtime.listType
rxlabz Oct 30, 2020
e7b5b5b
scope get unmodifiable _contexts
rxlabz Oct 30, 2020
5e083b1
add scope.apply precedence rules tests
rxlabz Oct 30, 2020
6c3dd9c
scope.apply tags & extras merging tests
rxlabz Oct 30, 2020
e834d73
fix scope.setContexts for num,bool, String values
rxlabz Oct 30, 2020
e5124dc
fix test
rxlabz Oct 30, 2020
38b6cb2
cleaning
rxlabz Oct 30, 2020
562fd90
add scope apply contexts tests
rxlabz Oct 30, 2020
49a0de5
add contexts custom fields tests
rxlabz Oct 30, 2020
9902732
add contexts clone custom fields test
rxlabz Oct 30, 2020
96f8682
fix scope apply context empty runtimes
rxlabz Oct 30, 2020
0a9362d
refactor _mergeEventContextsRuntimes
rxlabz Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add scope.setContexts conditions
  • Loading branch information
@rxlabz
rxlabz committed Oct 30, 2020
commit 00b5fbae55954ee9a35caa2c59e2eae36f1b3375
5 changes: 2 additions & 3 deletions dart/lib/src/scope.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,8 @@ class Scope {

/// add an entry to the Scope's contexts
void setContexts(String key, Object value) {
// TODO replace all assertions with ArgumentError ?
assert(key != null && value != null);
assert(value is num || value is bool || value is String);
if ((key != null && value != null) &&
!(value is num || value is bool || value is String)) return;

_contexts[key] = value;
}
Expand Down