Skip to content

DioEventProcessor: Append http response body #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 16 commits into from
Jul 26, 2023
Merged

DioEventProcessor: Append http response body #1557

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
642c435
add response body in failed request client
denrase Jul 17, 2023
aa95370
attach response data in dio event processor
denrase Jul 18, 2023
881a8d5
add changelog entry
denrase Jul 18, 2023
058eb25
Merge branch 'main' into feat/append-http-response-body
denrase Jul 18, 2023
d72d286
use Object ? instead of dynamic
denrase Jul 18, 2023
f9bdb8f
support all response body types
denrase Jul 18, 2023
fdee02a
Merge branch 'main' into feat/append-http-response-body
denrase Jul 24, 2023
326bff6
update changelog
denrase Jul 24, 2023
67cd866
revert logging of streamed response
denrase Jul 24, 2023
4b34e70
fix test expectations
denrase Jul 24, 2023
3340c39
Merge branch 'main' into feat/append-http-response-body
denrase Jul 25, 2023
101e319
update changelog entry
denrase Jul 25, 2023
3485b4f
one early return
denrase Jul 25, 2023
a2b682e
update changelog
denrase Jul 25, 2023
617aa24
use utf8JsonEncoder
denrase Jul 25, 2023
120b193
fix
marandaneto Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
one early return
  • Loading branch information
@denrase
denrase committed Jul 25, 2023
commit 3485b4f6a89bb72bce9e46c2239b22fe428c87af
5 changes: 1 addition & 4 deletions dio/lib/src/dio_event_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,7 @@ class DioEventProcessor implements EventProcessor {

/// Returns the response data, if possible according to the users settings.
Object? _getResponseData(Object? data, ResponseType responseType) {
if (!_options.sendDefaultPii) {
return null;
}
if (data == null) {
if (!_options.sendDefaultPii || data == null) {
return null;
}
switch (responseType) {
Expand Down