Skip to content

Make hint non-nullable in BeforeSendCallback, BeforeBreadcrumbCall and EventProcessor #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 13 commits into from
Sep 4, 2023
Merged

Make hint non-nullable in BeforeSendCallback, BeforeBreadcrumbCall and EventProcessor #1574

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
06729c6
Make hint non-nullable in BeforeSendCallback and BeforeBreadcrumbCall…
denrase Jul 31, 2023
ae67da2
Merge branch 'release/8.0.0' into enha/non-nullable-hint
denrase Jul 31, 2023
f7093ba
add changelog entry
denrase Jul 31, 2023
30942bb
test beforeBreadcrumb called with user provided hint
denrase Jul 31, 2023
0c16595
make other Hinte occurences non-null
denrase Aug 14, 2023
fff59b3
update changelog
denrase Aug 14, 2023
1605af0
Merge branch 'release/8.0.0' into enha/non-nullable-hint
denrase Aug 22, 2023
b8f0cc0
update changelog
denrase Aug 22, 2023
7601295
fix changelog
denrase Aug 22, 2023
6abc4e9
Merge branch 'release/8.0.0' into enha/non-nullable-hint
denrase Aug 29, 2023
e36b555
fix tests, add trailing commas
denrase Aug 29, 2023
22158ce
Merge branch 'release/8.0.0' into enha/non-nullable-hint
denrase Sep 4, 2023
b743814
update changelog
denrase Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'release/8.0.0' into enha/non-nullable-hint
  • Loading branch information
@denrase
denrase committed Sep 4, 2023
commit 22158ce001032f87345e156476cb443d6e04afe8
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- This change was introduced in [relay/#1690](https://github.com/getsentry/relay/pull/1690) and released with [22.12.0](https://github.com/getsentry/relay/releases/tag/22.12.0)
- Make `hint` non-nullable in `BeforeSendCallback`, `BeforeBreadcrumbCall` and `EventProcessor` ([#1574](https://github.com/getsentry/sentry-dart/pull/1574))
Copy link
Contributor

@github-actions github-actions bot Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 8.0.0.
    Consider moving the entry to the ## Unreleased section, please.

- This will affect your callbacks, making this a breaking change.
- Do not leak extensions of external classes ([#1576](https://github.com/getsentry/sentry-dart/pull/1576))

## Unreleased

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.