flutter native ios #161
Merged
flutter native ios #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Nov 13, 2020
marandaneto
reviewed
Nov 13, 2020
marandaneto
reviewed
Nov 13, 2020
marandaneto
reviewed
Nov 13, 2020
rxlabz
commented
Nov 16, 2020
marandaneto
reviewed
Nov 16, 2020
marandaneto
reviewed
Nov 16, 2020
Member
|
Can we please fix the swift-lint errors and warnings or add a config file to ignore some of them, if we think they don't make sense. These lint issues make it super hard to take a look at the PR. |
marandaneto
reviewed
Nov 17, 2020
marandaneto
reviewed
Nov 17, 2020
marandaneto
reviewed
Nov 17, 2020
marandaneto
reviewed
Nov 17, 2020
marandaneto
reviewed
Nov 17, 2020
rxlabz
commented
Nov 17, 2020
marandaneto
reviewed
Nov 20, 2020
marandaneto
reviewed
Nov 20, 2020
marandaneto
reviewed
Nov 20, 2020
marandaneto
reviewed
Nov 20, 2020
marandaneto
reviewed
Nov 20, 2020
marandaneto
reviewed
Nov 20, 2020
…lutter-native-ios # Conflicts: # flutter/lib/sentry_flutter.dart
…lutter-native-ios # Conflicts: # flutter/example/lib/main.dart
marandaneto
reviewed
Nov 20, 2020
| - Sentry (6.0.1): | ||
| - Sentry/Core (= 6.0.1) | ||
| - Sentry/Core (6.0.1) | ||
| - package_info (0.0.1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
add the iOS FlutterSentryPlugin with nativeSdkIntegration and loadContexts method channels
💡 Motivation and Context
handle iOS errors and enrich payload with iOS device infos
💚 How did you test it?
added some unit tests + integration tests
📝 Checklist
🔮 Next steps
More Unit tests