Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
buenaflor committed Sep 4, 2023
commit 867a2440e09c13a89c00d5d4f4f4fbb895d6517d
14 changes: 0 additions & 14 deletions dart/test/http_client/tracing_client_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -141,20 +141,6 @@ void main() {
expect(response.request!.headers[sentryTrace.name], sentryTrace.value);
});

test('captured span do not add headers if NoOp', () async {
final sut = fixture.getSut(
client: fixture.getClient(statusCode: 200, reason: 'OK'),
);

await fixture._hub
.configureScope((scope) => scope.span = NoOpSentrySpan());

final response = await sut.get(requestUri);

expect(response.request!.headers['baggage'], null);
expect(response.request!.headers['sentry-trace'], null);
});

test('captured span do not add headers if origins not set', () async {
final sut = fixture.getSut(
client: fixture.getClient(
Expand Down
3 changes: 3 additions & 0 deletions dart/test/mocks/mock_hub.dart
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ class MockHub with NoSuchMethodProvider implements Hub {
void setSpanContext(throwable, ISentrySpan span, String transaction) {
spanContextCals++;
}

@override
Scope get scope => Scope(_options);
}

class CaptureEventCall {
Expand Down
12 changes: 6 additions & 6 deletions dart/test/utils/tracing_utils_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,29 +50,29 @@ void main() {
});
});

group('$addSentryTraceHeader', () {
group('$addSentryTraceHeaderFromSpan', () {
final fixture = Fixture();

test('adds sentry trace header', () {
final headers = <String, String>{};
final sut = fixture.getSut();
final sentryHeader = sut.toSentryTrace();

addSentryTraceHeader(sut, headers);
addSentryTraceHeaderFromSpan(sut, headers);

expect(headers[sentryHeader.name], sentryHeader.value);
});
});

group('$addBaggageHeader', () {
group('$addBaggageHeaderFromSpan', () {
final fixture = Fixture();

test('adds baggage header', () {
final headers = <String, String>{};
final sut = fixture.getSut();
final baggage = sut.toBaggageHeader();

addBaggageHeader(sut, headers);
addBaggageHeaderFromSpan(sut, headers);

expect(headers[baggage!.name], baggage.value);
});
Expand All @@ -87,7 +87,7 @@ void main() {

final newValue = '$oldValue,${baggage!.value}';

addBaggageHeader(sut, headers);
addBaggageHeaderFromSpan(sut, headers);

expect(headers[baggage.name], newValue);
});
Expand All @@ -102,7 +102,7 @@ void main() {
final sut = fixture.getSut();
final baggage = sut.toBaggageHeader();

addBaggageHeader(sut, headers);
addBaggageHeaderFromSpan(sut, headers);

expect(headers[baggage!.name],
'other-vendor-value=foo,sentry-trace_id=${sut.context.traceId},sentry-public_key=abc,sentry-release=release,sentry-environment=environment,sentry-user_segment=segment,sentry-transaction=name,sentry-sample_rate=1');
Expand Down