Skip to content

refactor: native FFI for Android and Cocoa SDK #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaind wants to merge 6 commits into from
Closed

refactor: native FFI for Android and Cocoa SDK #1622

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66bc8b6
wip: cocoa SDK ffi
vaind Aug 31, 2023
5903fcf
android JNI ffi
vaind Sep 1, 2023
84d609c
experiment code backup
vaind Sep 1, 2023
0e98205
fixup cocoa ffigen dependency
vaind Sep 1, 2023
ae34a42
analyzer issues
vaind Sep 1, 2023
8367da2
update cocoa bindings
vaind Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
experiment code backup
  • Loading branch information
@vaind
vaind committed Sep 1, 2023
commit 84d609cbe919fa9acde4edd1e14f41954cbceca1
15 changes: 15 additions & 0 deletions flutter/lib/src/integrations/native_sdk_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import 'dart:async';
import 'dart:ffi';

import 'package:flutter/services.dart';
import 'package:jni/jni.dart';
import 'package:sentry/sentry.dart';
import '../sentry_cocoa.dart';
import '../sentry_flutter_options.dart';
import '../sentry_android.dart' as android;

/// Enables Sentry's native SDKs (Android and iOS) with options.
class NativeSdkIntegration implements Integration<SentryFlutterOptions> {
Expand All @@ -17,7 +21,15 @@ class NativeSdkIntegration implements Integration<SentryFlutterOptions> {
if (!options.autoInitializeNativeSdk) {
return;
}

try {
// XXX
// final nativeLib = SentryCocoa(DynamicLibrary.process());
// final orignalName = PrivateSentrySDKOnly.getSdkName(nativeLib).toString();
// PrivateSentrySDKOnly.setSdkName_(
// nativeLib, NSString(nativeLib, "Custom SDK name"));
// final newName = PrivateSentrySDKOnly.getSdkName(nativeLib).toString();

await _channel.invokeMethod('initNativeSdk', <String, dynamic>{
'dsn': options.dsn,
'debug': options.debug,
Expand Down Expand Up @@ -55,6 +67,9 @@ class NativeSdkIntegration implements Integration<SentryFlutterOptions> {
options.appHangTimeoutInterval.inMilliseconds,
});

// android.Sentry.setTag(
// JString.fromString("ffi-key"), JString.fromString("ffi-value"));

options.sdk.addIntegration('nativeSdkIntegration');
} catch (exception, stackTrace) {
options.logger(
Expand Down