Skip to content

Disable scope sync for cloned scopes #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 4 commits into from
Sep 11, 2023
Merged

Disable scope sync for cloned scopes #1628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ca1370
disable scope sync for cloned scopes
denrase Sep 5, 2023
880b737
run fix & format
denrase Sep 5, 2023
c8bc3cc
add changelog entry
denrase Sep 5, 2023
02b53d2
Merge branch 'main' into fix/incorrect-scope-tags
denrase Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
disable scope sync for cloned scopes
  • Loading branch information
@denrase
denrase committed Sep 5, 2023
commit 4ca137069c085e466cdc1071459ec245090795b7
6 changes: 4 additions & 2 deletions dart/lib/src/scope.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ class Scope {
List.unmodifiable(_eventProcessors);

final SentryOptions _options;
bool _enableScopeSync = true;

final List<SentryAttachment> _attachments = [];

Expand Down Expand Up @@ -412,7 +413,8 @@ class Scope {
..level = level
..fingerprint = List.from(fingerprint)
.._transaction = _transaction
..span = span;
..span = span
.._enableScopeSync = false;

clone._setUserSync(user);

Expand Down Expand Up @@ -450,7 +452,7 @@ class Scope {
}

Future<void> _callScopeObservers(_OnScopeObserver action) async {
if (_options.enableScopeSync) {
if (_options.enableScopeSync && _enableScopeSync) {
for (final scopeObserver in _options.scopeObservers) {
await action(scopeObserver);
}
Expand Down
8 changes: 8 additions & 0 deletions dart/test/scope_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,14 @@ void main() {
expect(1, fixture.mockScopeObserver.numberOfRemoveTagCalls);
});

test('clone has disabled scope sync', () async {
final sut = fixture.getSut(scopeObserver: fixture.mockScopeObserver);
final clone = sut.clone();

await clone.setContexts("fixture-contexts-key", "fixture-contexts-value");
expect(0, fixture.mockScopeObserver.numberOfSetContextsCalls);
});

group('Scope apply', () {
final scopeUser = SentryUser(
id: '800',
Expand Down