Skip to content

fix: android native integration #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marandaneto merged 4 commits into from
Nov 17, 2020
Merged

fix: android native integration #163

marandaneto merged 4 commits into from
Nov 17, 2020

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 17, 2020 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

fix: android native integration

💡 Motivation and Context

running and fixing issues on the way

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as draft November 17, 2020 11:28
@marandaneto marandaneto changed the base branch from main to feat/flutter-native November 17, 2020 11:28
@marandaneto marandaneto changed the title fix/android native integration fix: android native integration Nov 17, 2020
@marandaneto marandaneto requested a review from rxlabz November 17, 2020 11:41
rxlabz
rxlabz reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@rxlabz rxlabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto marked this pull request as ready for review November 17, 2020 13:12
@marandaneto marandaneto merged commit e48f974 into feat/flutter-native Nov 17, 2020
@marandaneto marandaneto deleted the fix/android-native-integration branch November 17, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

1 more reviewer

@rxlabz rxlabz rxlabz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marandaneto @rxlabz