Skip to content

Fix autoPerformanceTracingEnabled flag in Android plugin #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 1 commit into from
Sep 12, 2023
Merged

Fix autoPerformanceTracingEnabled flag in Android plugin #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {

private var activity: WeakReference<Activity>? = null
private var framesTracker: ActivityFramesTracker? = null
private var autoPerformanceTracingEnabled = false

override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) {
context = flutterPluginBinding.applicationContext
Expand Down Expand Up @@ -137,7 +136,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
}

private fun fetchNativeAppStart(result: Result) {
if (!autoPerformanceTracingEnabled) {
if (!sentryFlutter.autoPerformanceTracingEnabled) {
result.success(null)
return
}
Expand All @@ -161,7 +160,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
}

private fun beginNativeFrames(result: Result) {
if (!autoPerformanceTracingEnabled) {
if (!sentryFlutter.autoPerformanceTracingEnabled) {
result.success(null)
return
}
Expand All @@ -174,7 +173,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {

private fun endNativeFrames(id: String?, result: Result) {
val activity = activity?.get()
if (!autoPerformanceTracingEnabled || activity == null || id == null) {
if (!sentryFlutter.autoPerformanceTracingEnabled || activity == null || id == null) {
if (id == null) {
Log.w("Sentry", "Parameter id cannot be null when calling endNativeFrames.")
}
Expand Down