Skip to content

ci: generate code coverage in flutter integration test #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaind wants to merge 3 commits into from
Closed

ci: generate code coverage in flutter integration test #1667

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
537aa37
ci: generate code coverage in flutter integration test
vaind Oct 3, 2023
5baca7e
fix integration test coverage upload
vaind Oct 4, 2023
b427514
more codecov fixes
vaind Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix integration test coverage upload
  • Loading branch information
@vaind
vaind committed Oct 4, 2023
commit 5baca7e391d6d50819879fdff6ef93a8c51e237b
10 changes: 5 additions & 5 deletions .github/workflows/flutter_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
if: matrix.sdk == 'stable'
with:
name: sentry_flutter_integration_android
file: ./flutter/coverage/lcov.info
file: ./flutter/example/coverage/lcov.info

cocoa:
name: "${{ matrix.target }} | ${{ matrix.sdk }}"
Expand Down Expand Up @@ -160,18 +160,18 @@ jobs:

- name: run integration test
# Disable flutter integration tests for iOS for now (https://github.com/getsentry/sentry-dart/issues/1605#issuecomment-1695809346)
if: ${{ matrix.target != 'ios' }}
if: ${{ matrix.target == 'macos' }}
run: flutter test --coverage -d "${{ steps.device.outputs.name }}" integration_test --verbose

- name: run native test
# We only have the native unit test package in the iOS xcodeproj at the moment.
# Should be OK because it will likely be removed after switching to FFI (see https://github.com/getsentry/sentry-dart/issues/1444).
if: ${{ matrix.target != 'macos' }}
if: ${{ matrix.target == 'ios' }}
working-directory: ./flutter/example/${{ matrix.target }}
run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=${{ steps.device.outputs.platform }}" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO

- uses: codecov/codecov-action@d9f34f8cd5cb3b3eb79b3e4b5dae3a16df499a70 # pin@v3
if: matrix.sdk == 'stable'
if: ${{ matrix.sdk == 'stable' && matrix.target == 'macos' }}
with:
name: sentry_flutter_integration_cocoa
file: ./flutter/coverage/lcov.info
file: ./flutter/example/coverage/lcov.info