cache previous symbol collector successful uploads

.github/workflows/flutter-symbols.yml

@@ -1,6 +1,6 @@
 name: Flutter symbols collection
 on:
-  push: # Temporary so we get the workflow on the PR branch
+  push: # TODO REMOVE
   workflow_dispatch:
     inputs:
       flutter_version:
@@ -27,15 +27,24 @@ jobs:
   run:
     needs: [test]
     runs-on: ubuntu-latest
-    timeout-minutes: 60
     steps:
       - uses: actions/checkout@v3
 
       - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d # pin@v1
 
       - run: dart pub get
 
+      - uses: actions/download-artifact@v3
+        with:
+          name: flutter-symbol-collector-database
+          path: scripts/flutter_symbol_collector/.successful
+
       # - run: dart run bin/flutter_symbol_collector.dart --version=${{ inputs.flutter_version }}
-      - run: dart run bin/flutter_symbol_collector.dart --version=3.13.*
+      - run: dart run bin/flutter_symbol_collector.dart --version=3.13.8
         env:
           GITHUB_TOKEN: ${{ github.token }}
+
+      - uses: actions/upload-artifact@v3
+        with:
+          name: flutter-symbol-collector-database
+          path: scripts/flutter_symbol_collector/.successful

scripts/flutter_symbol_collector/.gitignore

@@ -2,4 +2,5 @@
 # Created by `dart pub`
 .dart_tool/
 
-.temp
+.temp
+.successful

scripts/flutter_symbol_collector/bin/flutter_symbol_collector.dart

@@ -11,6 +11,7 @@ final source = FlutterSymbolSource(
         : Authentication.withToken(githubToken));
 final fs = LocalFileSystem();
 final tempDir = fs.currentDirectory.childDirectory('.temp');
+final successDir = fs.currentDirectory.childDirectory('.successful');
 late final SymbolCollectorCli collector;
 
 void main(List<String> arguments) async {
@@ -25,6 +26,7 @@ void main(List<String> arguments) async {
   final argVersion = args['version'] as String;
 
   collector = await SymbolCollectorCli.setup(tempDir);
+  successDir.createSync(recursive: true);
 
   // If a specific version was given, run just for this version.
   if (argVersion.isNotEmpty &&
@@ -52,14 +54,36 @@ void main(List<String> arguments) async {
 }
 
 Future<void> processFlutterVerion(FlutterVersion version) async {
+  if (bool.hasEnvironment('CI')) {
+    print('::group::Processing Flutter ${version.tagName}');
+  }
   Logger.root.info('Processing Flutter ${version.tagName}');
   Logger.root.info('Engine version: ${await version.engineVersion}');
 
   final archives = await source.listSymbolArchives(version);
   final dir = tempDir.childDirectory(version.tagName);
+  final sdir = successDir.childDirectory(version.tagName.toLowerCase());
   for (final archive in archives) {
+    // Later, we'll write create an empty file to mark this as successful.
+    final sFile = sdir.childFile(archive.path.toLowerCase());
+    if (sFile.existsSync()) {
+      Logger.root
+          .info('Skipping ${archive.path} - already processed successfully');
+      continue;
+    }
+
     final archiveDir = dir.childDirectory(archive.platform.operatingSystem);
-    await source.downloadAndExtractTo(archiveDir, archive.path);
-    await collector.upload(archiveDir, archive.platform, version);
+    if (!await source.downloadAndExtractTo(archiveDir, archive.path)) {
+      continue;
+    }
+    if (!await collector.upload(archiveDir, archive.platform, version)) {
+      continue;
+    }
+
+    sFile.createSync(recursive: true);
+  }
+
+  if (bool.hasEnvironment('CI')) {
+    print('::endgroup::');
   }
 }

scripts/flutter_symbol_collector/lib/src/flutter_symbol_source.dart

@@ -31,6 +31,7 @@ class FlutterSymbolSource {
       .listTags(_flutterRepo, perPage: 30)
       .map((t) => FlutterVersion(t.name));
 
+  /// Returns false as the first record value in case there was any error fetching the symbol archives.
   Future<List<SymbolArchive>> listSymbolArchives(FlutterVersion version) async {
     // example: https://console.cloud.google.com/storage/browser/flutter_infra_release/flutter/9064459a8b0dcd32877107f6002cc429a71659d1
     final prefix = 'flutter/${await version.engineVersion}/';
@@ -73,7 +74,8 @@ class FlutterSymbolSource {
 
   /// Downloads the remote [filePath] to the given [target] directory.
   /// If it's an archive, extracts the content instead.
-  Future<void> downloadAndExtractTo(Directory target, String filePath) async {
+  /// returns `true` if the file was downloaded and extracted successfully.
+  Future<bool> downloadAndExtractTo(Directory target, String filePath) async {
     if (path.extension(filePath) == '.zip') {
       target = await target
           .childDirectory(path.withoutExtension(filePath))
@@ -89,6 +91,7 @@ class FlutterSymbolSource {
         _log.warning('Failed to download $filePath to $target', e, trace);
         // Remove the directory so that we don't leave a partial extraction.
         await target.delete(recursive: true);
+        return false;
       }
     } else {
       _log.fine('Downloading $filePath to $target');
@@ -104,8 +107,10 @@ class FlutterSymbolSource {
         _log.warning('Failed to download $filePath to $target', e, trace);
         await sink.close();
         await file.delete();
+        return false;
       }
     }
+    return true;
   }
 
   Future<void> _extractZip(Directory target, Archive archive) async {

scripts/flutter_symbol_collector/lib/src/symbol_collector_cli.dart

@@ -87,22 +87,28 @@ class SymbolCollectorCli {
 
   Future<String> getVersion() => _execute(['--version', '-h']);
 
-  Future<void> upload(
+  Future<bool> upload(
       Directory dir, Platform symbolsPlatform, FlutterVersion flutterVersion,
-      {bool dryRun = false}) {
+      {bool dryRun = false}) async {
     final type = symbolsPlatform.operatingSystem;
-    return _execute([
-      '--upload',
-      'directory',
-      '--path',
-      dir.path,
-      '--batch-type',
-      type,
-      '--bundle-id',
-      'flutter-${flutterVersion.tagName}-$type',
-      '--server-endpoint',
-      'https://symbol-collector.services.sentry.io/',
-    ]);
+    try {
+      await _execute([
+        '--upload',
+        'directory',
+        '--path',
+        dir.path,
+        '--batch-type',
+        type,
+        '--bundle-id',
+        'flutter-${flutterVersion.tagName}-$type',
+        '--server-endpoint',
+        'https://symbol-collector.services.sentry.io/',
+      ]);
+    } catch (e) {
+      _log.warning('Failed to upload symbols from ${dir.path}', e);
+      return false;
+    }
+    return true;
   }
 
   Future<String> _execute(List<String> arguments) async {