Skip to content

fix: unsupported types with expando #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 10 commits into from
Nov 10, 2023
Merged

fix: unsupported types with expando #1690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
564d818
Support string, int, double and bool as throwable for expando
buenaflor Oct 19, 2023
7b28d84
Rename the test file and move it to utils folder{
buenaflor Oct 19, 2023
2f8819c
Remvoe ffi import
buenaflor Oct 20, 2023
b052f89
Update changelog
buenaflor Oct 20, 2023
11035e2
Try other url for dio pubspec doc url
buenaflor Oct 20, 2023
ce89d78
Change doc url of logging pubspec
buenaflor Oct 20, 2023
b94578c
Merge branch 'main' into fix/expando-logging
buenaflor Oct 20, 2023
7079282
Remove unnecessary code
buenaflor Oct 20, 2023
12ec072
Update naming
buenaflor Oct 20, 2023
8370ad9
Rename
buenaflor Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary code
  • Loading branch information
@buenaflor
buenaflor committed Oct 20, 2023
commit 707928274da1f9dca8d29df65e8ca2f164cead43
2 changes: 0 additions & 2 deletions dart/lib/src/hub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,6 @@ class _WeakMap {
return;
}
throwable = exceptionsWrapperUtil.wrapIfUnsupportedType(throwable);
_expando[throwable];
try {
if (_expando[throwable] == null) {
_expando[throwable] = MapEntry(span, transaction);
Expand Down Expand Up @@ -631,7 +630,6 @@ class _WeakMap {
exception: exception,
stackTrace: stackTrace,
);
print('hahaa');
}
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion dart/test/utils/wrapper_exception_util_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ void main() {

final third =
exceptionWrapperUtil.wrapIfUnsupportedType(unsupportedThrowable);
expect(fixture.expando[third], 2);
expect(fixture.expando[third], 2.0);
});
});

Expand Down