Skip to content

Add attachScreenshotOnlyWhenResumed to options #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denrase merged 14 commits into from
Nov 7, 2023
Merged

Add attachScreenshotOnlyWhenResumed to options #1700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0cdf543
Introduce option to only attach screenshot if the app is in resumed s…
denrase Oct 24, 2023
3fb0854
add changelog entry
denrase Oct 24, 2023
38b8ded
add changelog entry
denrase Oct 24, 2023
5b7311a
Merge branch 'fix/background-screenshot-crash' of github.com:getsentr…
denrase Oct 24, 2023
40f86bc
remove debug code
denrase Oct 24, 2023
1329d49
cleanup
denrase Oct 24, 2023
e4f71f3
format
denrase Oct 24, 2023
c358bdf
Merge branch 'main' into fix/background-screenshot-crash
denrase Oct 24, 2023
11baf68
Merge branch 'main' into fix/background-screenshot-crash
denrase Oct 30, 2023
a38a2aa
import widget instead of ui
denrase Oct 30, 2023
3f8c8d0
fix changelog
denrase Oct 30, 2023
d2d8567
Rename option
denrase Nov 6, 2023
47eaceb
Merge branch 'main' into fix/background-screenshot-crash
denrase Nov 7, 2023
23438c5
update changelog
denrase Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@denrase
denrase committed Oct 24, 2023
commit e4f71f38c98c30cee2b4ed992587552753294f53
1 change: 0 additions & 1 deletion flutter/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ class MyApp extends StatefulWidget {
}

class _MyAppState extends State<MyApp> {

@override
Widget build(BuildContext context) {
return feedback.BetterFeedback(
Expand Down
4 changes: 2 additions & 2 deletions flutter/lib/src/event_processor/screenshot_event_processor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import '../sentry_flutter_options.dart';
import 'package:flutter/rendering.dart';
import '../renderer/renderer.dart';


class ScreenshotEventProcessor implements EventProcessor {
final SentryFlutterOptions _options;

Expand Down Expand Up @@ -40,7 +39,8 @@ class ScreenshotEventProcessor implements EventProcessor {
return event;
}

if (_options.attachScreenshotWhenResumed && WidgetsBinding.instance.lifecycleState != AppLifecycleState.resumed) {
if (_options.attachScreenshotWhenResumed &&
WidgetsBinding.instance.lifecycleState != AppLifecycleState.resumed) {
_options.logger(SentryLevel.debug,
'Only attaching screenshots when application state is resumed.');
return event;
Expand Down