Add markUnhandledAsFatal to SentryOptions
#1720
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/8.0.0 #1720 +/- ##
=================================================
- Coverage 91.12% 90.30% -0.82%
=================================================
Files 175 179 +4
Lines 5690 5850 +160
=================================================
+ Hits 5185 5283 +98
- Misses 505 567 +62 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ### Features | ||
|
|
||
| - Add `markUnhandledAsFatal` to `SentryOptions` ([#1720](https://github.com/getsentry/sentry-dart/pull/1720)) |
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 8.0.0.
Consider moving the entry to the## Unreleasedsection, please.
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
lgtm 👍
Any particular reason why this is in v8?
It would change the metrics significantly in the dashboards in a minor version. |
|
@buenaflor Also the naming of the flag is in reference to unhandled error, which is also new in v8. |
|
@buenaflor @ueman @feinstein I'm always unsure regarding naming. Is the it clear enough from the options name what it's intent is? |
|
Me too hehe, but I think it's ok, I always try to make my booleans start with |
|
Converting back to draft as we decided to base this on the main branch and update naming accordingly. |
|
Closed in favour of #1738 |
📜 Description
Add
markUnhandledAsFataloption toSentryOptions. When disabled the level for automatically trackedunhandledevetns will be set toerrorinstead offatal/💡 Motivation and Context
Relates to #1624
💚 How did you test it?
Unit tets
📝 Checklist
sendDefaultPiiis enabled