Skip to content

Fixes setting the correct locale to contexts with navigatorKey #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 9 commits into from
Nov 15, 2023
Merged

Fixes setting the correct locale to contexts with navigatorKey #1724

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ec24c3
Add localization with navigatorKey
buenaflor Nov 13, 2023
98f3521
Update CHANGELOG
buenaflor Nov 13, 2023
22644fa
Update tests
buenaflor Nov 13, 2023
ded8447
Update tests
buenaflor Nov 13, 2023
a9a610d
Format
buenaflor Nov 13, 2023
baf79a4
Remove unused import
buenaflor Nov 13, 2023
7f96dd0
Apply review improvements
buenaflor Nov 14, 2023
2ac3d22
Update CHANGELOG
buenaflor Nov 14, 2023
81862c4
Merge branch 'main' into fix/reported-language-not-matching
buenaflor Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG
  • Loading branch information
@buenaflor
buenaflor committed Nov 13, 2023
commit 98f3521820318d6e7f3a6a4a8b557fff0b8716bd
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

### Fixes

- Fixes setting the correct locale to contexts with navigatorKey ([#1724](https://github.com/getsentry/sentry-dart/pull/1724))
- If you have a selected locale in e.g MaterialApp, this fix will retrieve the correct locale in the event context.
- Unsupported types with Expando ([#1690](https://github.com/getsentry/sentry-dart/pull/1690))

### Features
Expand Down