Skip to content

improvements(example): fix router navigation issue and add improvements #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 7 commits into from
Dec 11, 2023
Merged

improvements(example): fix router navigation issue and add improvements #1767

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee4c549
Change http url and add route navigation observer example
buenaflor Nov 30, 2023
dcfc81d
Remove comment
buenaflor Nov 30, 2023
f6b0c1f
Improve sample
buenaflor Nov 30, 2023
ba5ec47
Format
buenaflor Nov 30, 2023
72de132
Add padding
buenaflor Nov 30, 2023
7c855a7
Merge branch 'main' into fix/example-cors-router-issues
buenaflor Nov 30, 2023
11d2c3e
Fix analyze issues
buenaflor Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add padding
  • Loading branch information
@buenaflor
buenaflor committed Nov 30, 2023
commit 72de1326467f877a39e6439fb8a92e13e0e96c2a
11 changes: 10 additions & 1 deletion flutter/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,16 @@ class MainScaffold extends StatelessWidget {
if (UniversalPlatform.isIOS || UniversalPlatform.isMacOS)
const CocoaExample(),
if (UniversalPlatform.isAndroid) const AndroidExample(),
],
].map((widget) {
if (kIsWeb) {
// Add vertical padding to web so the tooltip doesn't obstruct the clicking of the button below.
return Padding(
padding: const EdgeInsets.only(top: 18.0, bottom: 18.0),
child: widget,
);
}
return widget;
}).toList(),
),
),
);
Expand Down